[
https://issues.apache.org/jira/browse/KAFKA-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596601#comment-15596601
]
ASF GitHub Bot commented on KAFKA-4326:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/2053
KAFKA-4326: Refactor LogCleaner for better reuse of common copy/compress
logic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-4326
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2053
----
commit 9954ed9a23716ca88ec6ebb5db82e66505df13e2
Author: Jason Gustafson <[email protected]>
Date: 2016-10-12T21:55:10Z
KAFKA-4326: Refactor LogCleaner for better reuse of common copy/compress
logic
----
> Refactor LogCleaner to remove duplicate log copying logic
> ---------------------------------------------------------
>
> Key: KAFKA-4326
> URL: https://issues.apache.org/jira/browse/KAFKA-4326
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
>
> I think there's some code duplication in the log cleaner with respect to the
> copying of the log and re-compression after cleaning. We have similar logic
> already in {{ByteBufferMessageSet}} which we can potentially reuse. This
> improves encapsulation so that message format changes in the future become a
> little easier (since they touch fewer components).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
