[
https://issues.apache.org/jira/browse/KAFKA-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15637661#comment-15637661
]
ASF GitHub Bot commented on KAFKA-4380:
---------------------------------------
GitHub user holdenk opened a pull request:
https://github.com/apache/kafka/pull/2104
[KAFKA-4380] Remove cleanshutdownfile
This PR removes the cleanshutdownfile as suggested in the code comments as
a TODO.
Use of this seems to be well covered by existing tests (some of which
needed to be updated).
The gradlew unit tests pass locally on my machine, but since this is my
first (small) PR to Kafka I may have left something out.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/kafka
KAFKA-4380-remove-cleanshutdownfile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2104
----
commit 157b8523ac5de7f8c954889f0a719b956810fb76
Author: Holden Karau <hol...@us.ibm.com>
Date: 2016-09-28T20:28:31Z
Get rid of CleanShutdownFile now that we are well past 0.8.2 :)
commit 245814cfbf36b19fdeab7900de0e56386a62f6f6
Author: Holden Karau <hol...@us.ibm.com>
Date: 2016-11-01T15:34:10Z
More fixes
----
> Remove CleanShutdownFile as 0.8.2 has been released
> ---------------------------------------------------
>
> Key: KAFKA-4380
> URL: https://issues.apache.org/jira/browse/KAFKA-4380
> Project: Kafka
> Issue Type: Improvement
> Components: log
> Reporter: holdenk
> Priority: Trivial
>
> There is a TODO in the code to remove CleanShutdownFile after 0.8.2 is
> shipped, which has happened.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
