[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665194#comment-15665194 ]
Mark Shelton commented on KAFKA-4322: ------------------------------------- >> Is there any particular reasons that you want to commit offsets after >> restoration? This is the purpose of diagnosis, logging and recovery statistics only. This is to make it easier to tell me that N keys were restored since a begin and end callback allow me to log details and report progress and metrics regarding restoration. I do not want to commit offsets and the data that is made available is only for metrics. >> I'm wondering if you have other common requests that would benefit from the >> additional callbacks? Not currently no. >> If you feel that this is still a common feature that we should add to Kafka This is such a minor change with zero impact I don't see that one needs a KIP for that. > StateRestoreCallback begin and end indication > --------------------------------------------- > > Key: KAFKA-4322 > URL: https://issues.apache.org/jira/browse/KAFKA-4322 > Project: Kafka > Issue Type: Improvement > Components: streams > Affects Versions: 0.10.1.0 > Reporter: Mark Shelton > Assignee: Mark Shelton > Priority: Minor > > In Kafka Streams, the StateRestoreCallback interface provides only a single > method "restore(byte[] key, byte[] value)" that is called for every key-value > pair to be restored. > It would be nice to have "beginRestore" and "endRestore" methods as part of > StateRestoreCallback. > Kafka Streams would call "beginRestore" before restoring any keys, and would > call "endRestore" when it determines that it is done. This allows an > implementation, for example, to report on the number of keys restored and > perform a commit after the last key was restored. Other uses are conceivable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)