[
https://issues.apache.org/jira/browse/KAFKA-4404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786227#comment-15786227
]
ASF GitHub Bot commented on KAFKA-4404:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/2296
KAFKA-4404: Add javadocs to document core Connect types, especially that
integer types are signed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka
kafka-4404-document-connect-signed-integer-types
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2296
----
commit 0cc67cf094bdbf4d3dffc863a88e9c19d62d8887
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2016-12-29T22:00:33Z
KAFKA-4404: Add javadocs to document core Connect types, especially that
integer types are signed
----
> Add knowledge of sign to numeric schema types
> ---------------------------------------------
>
> Key: KAFKA-4404
> URL: https://issues.apache.org/jira/browse/KAFKA-4404
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Affects Versions: 0.10.0.1
> Reporter: Andy Bryant
> Assignee: Ewen Cheslack-Postava
> Priority: Minor
>
> For KafkaConnect schemas there is currently no concept of whether a numeric
> field is signed or unsigned.
> Add an additional `signed` attribute (like optional) or make it explicit that
> numeric types must be signed.
> You could encode this as a parameter on the schema but this would not be
> standard across all connectors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
