[
https://issues.apache.org/jira/browse/KAFKA-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796370#comment-15796370
]
ASF GitHub Bot commented on KAFKA-3856:
---------------------------------------
GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/2301
[WIP] [KAFKA-3856] Move inner classes accessible only functions in
TopologyBuilder out of public APIs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka kafka-3856-topology-builder-API
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2301
----
commit 5f72afbeb0dfb5bc0e1c5d686d701ca064102b8d
Author: Matthias J. Sax <[email protected]>
Date: 2016-12-17T07:23:12Z
[WIP] [KAFKA-3856] Move inner classes accessible only functions in
TopologyBuilder out of public APIs
----
> Move inner classes accessible only functions in TopologyBuilder out of public
> APIs
> ----------------------------------------------------------------------------------
>
> Key: KAFKA-3856
> URL: https://issues.apache.org/jira/browse/KAFKA-3856
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: Guozhang Wang
> Assignee: Matthias J. Sax
> Labels: api, needs-kip
>
> In {{TopologyBuilder}} there are a couple of public functions that are
> actually only used in the internal classes such as StreamThread and
> StreamPartitionAssignor, and some accessible only in high-level DSL inner
> classes, examples include {{addInternalTopic}}, {{sourceGroups}} and
> {{copartitionGroups}}, etc. But they are still listed in Javadocs since this
> class is part of public APIs.
> We should think about moving them out of the public functions. Unfortunately
> there is no "friend" access mode as in C++, so we need to think of another
> way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
