Thanks for the review, Guozhang, addressed comment 1, 3 on the KIP and left 2 for Eno to comment on. (He is back tomorrow)
-aarti On Tue, Jan 3, 2017 at 11:12 AM, Guozhang Wang <wangg...@gmail.com> wrote: > Thanks for the proposed KIP. Overall LGTM. > > A few comments: > > 1. "at the granularity of each processor node, in the addition to the > global rate" > > I think you also add one sensor at the granularity of tasks, "Skipped > records sensor in StreamTask" right? > > 2. From PR 1446 it seems you have also added a couple of APIs for allowing > users to register arbitrary sensors via `StreamsMetrics`, could you also > describe the changes and when / how users are expected to use them as well? > > 3. Could you also list the added overloaded APIs for throughput sensors as > well as with the recordLevel parameters, and mention what will be the > default values for those added parameters in the existing API functions? > > > > Guozhang > > > On Fri, Dec 30, 2016 at 8:26 PM, Aarti Gupta <aartigup...@gmail.com> > wrote: > > > Hi all, > > > > I would like to start the discussion on KIP-104: Granular Sensors for > > Streams > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-104% > > 3A+Granular+Sensors+for+Streams?src=contextnavchildmode> > > > > *https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=67636480 > > <https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=67636480 > > >* > > > > Looking forward to your feedback. > > > > Thanks, > > Aarti and Eno > > > > > > -- > -- Guozhang >
