[
https://issues.apache.org/jira/browse/KAFKA-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822571#comment-15822571
]
ASF GitHub Bot commented on KAFKA-3857:
---------------------------------------
GitHub user kiranptivo opened a pull request:
https://github.com/apache/kafka/pull/2378
KAFKA-3857 Additional log cleaner metrics
Fixes KAFKA-3857
Changes proposed in this pull request:
An additional log cleaner metric has been added:
time-since-last-run-ms: Time since the last log cleaner run, in
milliseconds. This metric would be reset to 0 every time log cleaner thread
runs. If this metric keeps constantly increasing, it indicates that the log
cleaner thread is not alive.
If you are creating alerts around log cleaner, you could monitor this
metric. A high "time-since-last-run-ms" value (eg: 600000) indicates that the
log cleaner hasn't been running since the last 10 minutes.
The code has been tested. JMX metric has been verified.
Note: This pull request is a continuation of the following pull request.
PR#1593 was quite old and I had some trouble rebasing it. Decided to start a
fresh PR.
https://github.com/apache/kafka/pull/1593/files/927b28cf41275874945beb7377f7f36c462f27c8#diff-ca1c127eee4b3c748ae73028f6abeab8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiranptivo/kafka log_cleaner_jmx_metric
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2378
----
commit a8635ff4a13e66b3f142ad97fff0ab082ecaf466
Author: Kiran Pillarisetty <pillarise...@tivo.com>
Date: 2017-01-14T00:23:45Z
Added a new metric time-since-last-run-ms, to track the time since the last
log cleaner run, in milli seconds
----
> Additional log cleaner metrics
> ------------------------------
>
> Key: KAFKA-3857
> URL: https://issues.apache.org/jira/browse/KAFKA-3857
> Project: Kafka
> Issue Type: Improvement
> Reporter: Kiran Pillarisetty
>
> The proposal would be to add a couple of additional log cleaner metrics:
> 1. Time of last log cleaner run
> 2. Cumulative number of successful log cleaner runs since last broker restart.
> Existing log cleaner metrics (max-buffer-utilization-percent,
> cleaner-recopy-percent, max-clean-time-secs, max-dirty-percent) do not
> differentiate an idle log cleaner from a dead log cleaner. It would be useful
> to have the above two metrics added, to indicate whether log cleaner is alive
> (and successfully cleaning) or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
