Hi Mayuresh, Thanks for updating the KIP. A couple of questions:
1. PrincipalBuilder implements Configurable and gets a map of properties via the `configure` method. Do we really need a new `buildPrincipal` method given that? 2. Jun suggested in the JIRA that it may make sense to pass the `channelPrincipal` as a field in `Session` instead of `KafkaPrincipal`. It would be good to understand why this was rejected. Ismael On Thu, Jan 12, 2017 at 7:07 PM, Ismael Juma <ism...@juma.me.uk> wrote: > Hi Mayuresh, > > Thanks for the KIP. A quick comment before I do a more detailed analysis, > the KIP says: > > `This KIP is a pure addition to existing functionality and does not > include any backward incompatible changes.` > > However, the KIP is proposing the addition of a method to the > PrincipalBuilder pluggable interface, which is not a compatible change. > Existing implementations would no longer compile, for example. It would be > good to make this clear in the KIP. > > Ismael > > On Thu, Jan 12, 2017 at 5:44 PM, Mayuresh Gharat < > gharatmayures...@gmail.com> wrote: > >> Hi all. >> >> We created KIP-111 to propose that Kafka should preserve the Principal >> generated by the PrincipalBuilder while processing the request received on >> socket channel, on the broker. >> >> Please find the KIP wiki in the link >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=67638388 >> . >> We would love to hear your comments and suggestions. >> >> >> Thanks, >> >> Mayuresh >> > >
