[
https://issues.apache.org/jira/browse/KAFKA-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated KAFKA-4767:
-------------------------------
Description:
The {{KafkaProducer}} is not properly joining the thread it creates. The code
is like this:
{code}
try {
this.ioThread.join(timeUnit.toMillis(timeout));
} catch (InterruptedException t) {
firstException.compareAndSet(null, t);
log.error("Interrupted while joining ioThread", t);
}
{code}
If the code is interrupted while performing the join, it will end up leaving
the io thread running. The correct way of handling this is a follows:
{code}
try {
this.ioThread.join(timeUnit.toMillis(timeout));
} catch (InterruptedException t) {
// propagate the interrupt
this.ioThread.interrupt();
try {
// join again (if you want to be more accurate, you can re-adjust the
timeout)
this.ioThread.join(timeUnit.toMillis(timeout));
} catch (InterruptedException t) {
firstException.compareAndSet(null, t);
log.error("Interrupted while joining ioThread", t);
} finally {
// make sure we maintain the interrupted status
Thread.currentThread.interrupt();
}
}
{code}
was:
The {{KafkaProducer}} is not properly joining the thread it creates. The code
is like this:
{code}
try {
this.ioThread.join(timeUnit.toMillis(timeout));
} catch (InterruptedException t) {
firstException.compareAndSet(null, t);
log.error("Interrupted while joining ioThread", t);
}
{code}
If the code is interrupted while performing the join, it will end up leaving
the io thread running. The correct way of handling this is a follows:
{code}
try {
this.ioThread.join(timeUnit.toMillis(timeout));
} catch (InterruptedException t) {
// propagate the interrupt
this.ioThread.interrupt();
try {
// join again (if you want to be more accurate, you can re-adjust the
time)
this.ioThread.join(timeUnit.toMillis(timeout));
} catch (InterruptedException t) {
firstException.compareAndSet(null, t);
log.error("Interrupted while joining ioThread", t);
} finally {
// make sure we maintain the interrupted status
Thread.currentThread.interrupt();
}
}
{code}
> KafkaProducer is not joining the thread properly
> ------------------------------------------------
>
> Key: KAFKA-4767
> URL: https://issues.apache.org/jira/browse/KAFKA-4767
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.11.0.0
> Reporter: Buğra Gedik
> Priority: Minor
>
> The {{KafkaProducer}} is not properly joining the thread it creates. The code
> is like this:
> {code}
> try {
> this.ioThread.join(timeUnit.toMillis(timeout));
> } catch (InterruptedException t) {
> firstException.compareAndSet(null, t);
> log.error("Interrupted while joining ioThread", t);
> }
> {code}
> If the code is interrupted while performing the join, it will end up leaving
> the io thread running. The correct way of handling this is a follows:
> {code}
> try {
> this.ioThread.join(timeUnit.toMillis(timeout));
> } catch (InterruptedException t) {
> // propagate the interrupt
> this.ioThread.interrupt();
> try {
> // join again (if you want to be more accurate, you can re-adjust
> the timeout)
> this.ioThread.join(timeUnit.toMillis(timeout));
> } catch (InterruptedException t) {
> firstException.compareAndSet(null, t);
> log.error("Interrupted while joining ioThread", t);
> } finally {
> // make sure we maintain the interrupted status
> Thread.currentThread.interrupt();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
