[ https://issues.apache.org/jira/browse/KAFKA-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873190#comment-15873190 ]
ASF GitHub Bot commented on KAFKA-4774: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2558 > Inner classes which don't need a reference to the outer class should be static > ------------------------------------------------------------------------------ > > Key: KAFKA-4774 > URL: https://issues.apache.org/jira/browse/KAFKA-4774 > Project: Kafka > Issue Type: Improvement > Reporter: Colin P. McCabe > Assignee: Colin P. McCabe > > Inner classes which don't need a reference to the outer class should be > static. This takes up less space in memory, generates less load on the > garbage collector, and eliminates a findbugs warning. -- This message was sent by Atlassian JIRA (v6.3.15#6346)