GitHub user original-brownbear opened a pull request:

    https://github.com/apache/kafka/pull/2632

    KAFKA-3182: Fix Transient Test Failure 
(kafka.network.SocketServerTest.testSocketsCloseOnShutdown)

    Fixes https://issues.apache.org/jira/browse/KAFKA-3182 by:
    * Turning off Nagle on the sending sockets to force the socket to 
physically acknowledge after the first write in `sendRequest`
    * (Still had to do this on Linux though not on Mac) Adding a `10ms` delay 
between writes (my guess would be [Slow 
Start](https://en.wikipedia.org/wiki/TCP_congestion_control#Slow_start) is to 
blame for this, but with Nagle off 10ms should more than suffice here imo)
    
    Before:
    
![before](https://cloud.githubusercontent.com/assets/6490959/23545356/5015f6a6-fffb-11e6-88f2-418e286a920d.png)
    
    After:
    
    
![after](https://cloud.githubusercontent.com/assets/6490959/23545331/32265096-fffb-11e6-8843-017580dacfc5.png)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/original-brownbear/kafka KAFKA-3182

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2632
    
----
commit dca46cf7bb822daaba30bf7683f300d4f8428742
Author: Armin Braun <armin.br...@1und1.de>
Date:   2017-03-03T09:01:09Z

    KAFKA-3182 Turn off Nagle

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to