[ https://issues.apache.org/jira/browse/KAFKA-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893974#comment-15893974 ]
ASF GitHub Bot commented on KAFKA-3182: --------------------------------------- GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2632 KAFKA-3182: Fix Transient Test Failure (kafka.network.SocketServerTest.testSocketsCloseOnShutdown) Fixes https://issues.apache.org/jira/browse/KAFKA-3182 by: * Turning off Nagle on the sending sockets to force the socket to physically acknowledge after the first write in `sendRequest` * (Still had to do this on Linux though not on Mac) Adding a `10ms` delay between writes (my guess would be [Slow Start](https://en.wikipedia.org/wiki/TCP_congestion_control#Slow_start) is to blame for this, but with Nagle off 10ms should more than suffice here imo) Before: ![before](https://cloud.githubusercontent.com/assets/6490959/23545356/5015f6a6-fffb-11e6-88f2-418e286a920d.png) After: ![after](https://cloud.githubusercontent.com/assets/6490959/23545331/32265096-fffb-11e6-8843-017580dacfc5.png) You can merge this pull request into a Git repository by running: $ git pull https://github.com/original-brownbear/kafka KAFKA-3182 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2632.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2632 ---- commit dca46cf7bb822daaba30bf7683f300d4f8428742 Author: Armin Braun <armin.br...@1und1.de> Date: 2017-03-03T09:01:09Z KAFKA-3182 Turn off Nagle ---- > Failure in kafka.network.SocketServerTest.testSocketsCloseOnShutdown > -------------------------------------------------------------------- > > Key: KAFKA-3182 > URL: https://issues.apache.org/jira/browse/KAFKA-3182 > Project: Kafka > Issue Type: Sub-task > Reporter: Guozhang Wang > Assignee: Armin Braun > Labels: transient-unit-test-failure > > {code} > Stacktrace > org.scalatest.junit.JUnitTestFailedError: expected exception when writing to > closed trace socket > at > org.scalatest.junit.AssertionsForJUnit$class.newAssertionFailedException(AssertionsForJUnit.scala:102) > at > org.scalatest.junit.JUnitSuite.newAssertionFailedException(JUnitSuite.scala:79) > at org.scalatest.Assertions$class.fail(Assertions.scala:1328) > at org.scalatest.junit.JUnitSuite.fail(JUnitSuite.scala:79) > at > kafka.network.SocketServerTest.testSocketsCloseOnShutdown(SocketServerTest.scala:180) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50) > at sun.reflect.GeneratedMethodAccessor11.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106) > at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360) > at > org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54) > at > org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:744) > {code} > Example: > https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/2181/testReport/junit/kafka.network/SocketServerTest/testSocketsCloseOnShutdown/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)