[ https://issues.apache.org/jira/browse/KAFKA-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927399#comment-15927399 ]
Ismael Juma edited comment on KAFKA-4907 at 3/16/17 3:11 AM: ------------------------------------------------------------- I think Jun is suggesting that defaulting to `retention.ms` only makes sense if retention by time is enabled. For compacted topics without `cleanup.policy` of `delete`, retention by time is basically disabled. So, in that case, the default should be infinite as it was before. Not sure what is the best way to achieve this though. was (Author: ijuma): I think Jun is suggesting that defaulting to `retention.ms` only makes sense if retention by time is enabled. For compacted topics without `cleanup.policy` of `delete`, retention is basically disabled. So, in that case, the default should be infinite as it was before. Not sure what is the best way to achieve this though. > compacted topic shouldn't reject messages with old timestamp > ------------------------------------------------------------ > > Key: KAFKA-4907 > URL: https://issues.apache.org/jira/browse/KAFKA-4907 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.10.1.0 > Reporter: Jun Rao > > In LogValidator.validateTimestamp(), we check the validity of the timestamp > in the message without checking whether the topic is compacted or not. This > can cause messages to a compacted topic to be rejected when it shouldn't. -- This message was sent by Atlassian JIRA (v6.3.15#6346)