Hi, Colin,
Thanks for the KIP. Looks good overall. A few comments below.
1. Sometimes we return
CompletableFuture<Map<String, TopicDescription>>
and some other times we return
Map<String, CompletableFuture<Void>>
, which doesn't seem consistent. Is that intentional?
2. We support batching in CreateTopic/DeleteTopic/ListTopic, but not in
DescribeTopic. Should we add batching in DescribeTopic to make it
consistent? Also, both ListTopic and DescribeTopic seem to return
TopicDescription. Could we just consolidate the two by just keeping
DescribeTopic?
3. listNodes: At the request protocol level, we can get things like
clusterId and controller broker id. Both are useful info from an admin
perspective, but are not exposed through the api. Perhaps we can generalize
listNodes to sth like describeCluster so that we can return those
additional info as well?
4. Configurations: To support security, we will need to include all
properties related to SSL and SASL.
Thanks,
Jun
On Thu, Mar 16, 2017 at 11:59 PM, Colin McCabe <cmcc...@apache.org> wrote:
> Hi all,
>
> It seems like people agree with the basic direction of the proposal and
> the API, including the operations that are included, the async and
> batching support, and the mechanisms for extending it in the future. If
> there's no more votes, I'd like to close the vote and start progress on
> this.
>
> I think the API should be unstable for a while (at least until the 0.11
> release is made), so we can consider ways to improve it. A few have
> been suggested here: removing or adding functions, renaming things a
> bit, or using request objects instead of options objects. I think once
> people try out the API a bit, it will be easier to evaluate these.
>
> best,
> Colin
>
>
> On Tue, Mar 14, 2017, at 10:12, Dong Lin wrote:
> > +1
> >
> > On Tue, Mar 14, 2017 at 8:50 AM, Grant Henke <ghe...@cloudera.com>
> wrote:
> >
> > > +1
> > >
> > > On Tue, Mar 14, 2017 at 2:44 AM, Sriram Subramanian <r...@confluent.io>
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > Nice work in driving this.
> > > >
> > > > On Mon, Mar 13, 2017 at 10:31 PM, Gwen Shapira <g...@confluent.io>
> > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > I expressed few concerns in the discussion thread, but in general
> this
> > > is
> > > > > super important to get done.
> > > > >
> > > > > On Fri, Mar 10, 2017 at 10:38 AM, Colin McCabe <cmcc...@apache.org
> >
> > > > wrote:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > I'd like to start voting on KIP-117
> > > > > > (https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > > 117%3A+Add+a+public+AdminClient+API+for+Kafka+admin+operations
> > > > > > ).
> > > > > >
> > > > > > The discussion thread can be found here:
> > > > > > https://www.mail-archive.com/dev@kafka.apache.org/msg65697.html
> > > > > >
> > > > > > best,
> > > > > > Colin
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > *Gwen Shapira*
> > > > > Product Manager | Confluent
> > > > > 650.450.2760 | @gwenshap
> > > > > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> > > > > <http://www.confluent.io/blog>
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Grant Henke
> > > Software Engineer | Cloudera
> > > gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
> > >
>
