[
https://issues.apache.org/jira/browse/KAFKA-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951644#comment-15951644
]
Colin P. McCabe commented on KAFKA-4995:
----------------------------------------
{code}
Bad practice Warnings
Code Warning
Eq org.apache.kafka.streams.processor.internals.Stamped defines
compareTo(Object) and uses Object.equals()
Eq
org.apache.kafka.streams.processor.internals.StreamPartitionAssignor$AssignedPartition
defines compareTo(StreamPartitionAssignor$AssignedPartition) and uses
Object.equals()
Correctness Warnings
Code Warning
NP Null passed for non-null parameter of new
TopologyBuilder$ProcessorNodeFactory(String, String[], ProcessorSupplier) in
org.apache.kafka.streams.processor.TopologyBuilder.addProcessor(String,
ProcessorSupplier, String[])
NP Null passed for non-null parameter of
org.apache.kafka.streams.processor.internals.QuickUnion.unite(Object, Object[])
in org.apache.kafka.streams.processor.TopologyBuilder.addSink(String, String,
Serializer, Serializer, StreamPartitioner, String[])
Multithreaded correctness Warnings
Code Warning
AT Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be
atomic in
org.apache.kafka.streams.state.internals.Segments.getOrCreateSegment(long,
ProcessorContext)
IS Inconsistent synchronization of
org.apache.kafka.streams.KafkaStreams.stateListener; locked 66% of time
IS Inconsistent synchronization of
org.apache.kafka.streams.processor.internals.StreamThread.stateListener; locked
66% of time
IS Inconsistent synchronization of
org.apache.kafka.streams.processor.TopologyBuilder.applicationId; locked 50% of
time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.CachingKeyValueStore.context; locked
66% of time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.CachingWindowStore.cache; locked 60%
of time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.CachingWindowStore.context; locked 66%
of time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.CachingWindowStore.name; locked 60% of
time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.CachingWindowStore.serdes; locked 70%
of time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.RocksDBStore.db; locked 63% of time
IS Inconsistent synchronization of
org.apache.kafka.streams.state.internals.RocksDBStore.serdes; locked 76% of
time
Performance Warnings
Code Warning
UrF Unread field:
org.apache.kafka.streams.state.internals.InMemoryKeyValueLoggedStore.context
WMI
org.apache.kafka.streams.kstream.internals.KStreamWindowReduce$KStreamWindowReduceProcessor.process(Object,
Object) makes inefficient use of keySet iterator instead of entrySet iterator
WMI
org.apache.kafka.streams.processor.internals.ProcessorStateManager.checkpoint(Map)
makes inefficient use of keySet iterator instead of entrySet iterator
WMI
org.apache.kafka.streams.processor.internals.StreamThread.maybeUpdateStandbyTasks()
makes inefficient use of keySet iterator instead of entrySet iterator
WMI
org.apache.kafka.streams.processor.internals.StreamThread.toString(String)
makes inefficient use of keySet iterator instead of entrySet iterator
WMI
org.apache.kafka.streams.processor.internals.StreamThread.toString(String)
makes inefficient use of keySet iterator instead of entrySet iterator
Dodgy code Warnings
Code Warning
IA Potentially ambiguous invocation of either an outer or inherited method
java.util.HashMap.size() in
org.apache.kafka.streams.state.internals.MemoryLRUCache$1.removeEldestEntry(Map$Entry)
{code}
> Fix remaining findbugs warnings in Kafka Streams
> ------------------------------------------------
>
> Key: KAFKA-4995
> URL: https://issues.apache.org/jira/browse/KAFKA-4995
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
>
> Fix some remaining findbugs warnings in Kafka Streams
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
