[ 
https://issues.apache.org/jira/browse/KAFKA-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958681#comment-15958681
 ] 

Ismael Juma commented on KAFKA-5018:
------------------------------------

Also, there are a few magic values in tests like LogCleanerTest. It would be 
good to document how one arrives to the correct values for things like the 
number of bytes in the array and configs like SegmentBytesProp.

> LogCleaner tests to verify behaviour of message format v2
> ---------------------------------------------------------
>
>                 Key: KAFKA-5018
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5018
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, core, producer 
>            Reporter: Ismael Juma
>             Fix For: 0.11.0.0
>
>
> It would be good to add LogCleaner tests to verify the behaviour of fields 
> like baseOffset after compaction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to