GitHub user arunmahadevan opened a pull request:
https://github.com/apache/kafka/pull/2820
KAFKA-5039: Logging in BlockingChannel and SyncProducer connect
When an exception is thrown in BlockingChannel::connect, the connection is
disconnected but the actual exception is not logged. This later manifests as
ClosedChannelException when trying to send. Also the SyncProducer wrongfully
logs "Connected to host:port for producing" even in case of exceptions.
The proposed patch logs the exception in BlockingChannel::connect in debug
level and logs the "Connected" message in SyncProducer only on successful
connection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/kafka KAFKA-5039
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2820
----
commit 41ba92d6417f72a205b38988519ed462f967700a
Author: Arun Mahadevan <[email protected]>
Date: 2017-04-07T06:07:57Z
KAFKA-5039: Logging in BlockingChannel and SyncProducer connect
When an exception is thrown in BlockingChannel::connect, the connection is
disconnected but the actual exception is not logged. This later manifests as
ClosedChannelException when trying to send. Also the SyncProducer wrongfully
logs "Connected to host:port for producing" even in case of exceptions.
The proposed patch logs the exception in BlockingChannel::connect in debug
level and logs the "Connected" message in SyncProducer only on successful
connection.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
