[
https://issues.apache.org/jira/browse/KAFKA-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961042#comment-15961042
]
ASF GitHub Bot commented on KAFKA-5042:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/2823
KAFKA-5042: InFlightRequests#isEmpty() always returns false
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-5042-fix-inflight-requests-is-empty
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2823
----
commit 1e7ea9611a5b788d21e32b5c0004c7068ee3d7e2
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-04-07T16:17:30Z
KAFKA-5042: InFlightRequests#isEmpty() always returns false
----
> InFlightRequests#isEmpty() always returns false
> -----------------------------------------------
>
> Key: KAFKA-5042
> URL: https://issues.apache.org/jira/browse/KAFKA-5042
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: Tommy Becker
> Assignee: Ismael Juma
> Fix For: 0.11.0.0
>
>
> While perusing the NetworkClient code I came across the following:
> InFlightRequests#isEmpty() always returns false.
> {code}
> public boolean isEmpty() {
> for (Deque<NetworkClient.InFlightRequest> deque :
> this.requests.values()) {
> if (!deque.isEmpty())
> return false;
> }
> return false;
> }
> {code}
> This method looks like a recent addtion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
