[
https://issues.apache.org/jira/browse/KAFKA-5056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965198#comment-15965198
]
ASF GitHub Bot commented on KAFKA-5056:
---------------------------------------
GitHub user toddpalino opened a pull request:
https://github.com/apache/kafka/pull/2843
KAFKA-5056: Add shuffling of FetchRequest requestInfo back to old consumer
KIP-74 removed the shuffle of requestInfo from the FetchRequest
constructor, moving the logic to the replica fetcher and new consumer API. This
adds a shuffle back to the old consumer that uses the same logic as the
deprecated constructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/toddpalino/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2843
----
commit c05916e4ab97765e9d00dd2bbe31c8b9e3a7e748
Author: tpalino <[email protected]>
Date: 2017-04-12T00:26:31Z
Add shuffling of FetchRequest requestInfo back to old consumer
KIP-74 removed the shuffle of requestInfo from the FetchRequest
constructor, moving the logic to the replica fetcher and new consumer API. This
adds a shuffle back to the old consumer that uses the same logic as the
deprecated constructor.
----
> Shuffling of partitions in old consume fetch requests removed
> -------------------------------------------------------------
>
> Key: KAFKA-5056
> URL: https://issues.apache.org/jira/browse/KAFKA-5056
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.10.1.0
> Reporter: Todd Palino
> Assignee: Todd Palino
>
> [KIP-74|https://cwiki.apache.org/confluence/display/KAFKA/KIP-74%3A+Add+Fetch+Response+Size+Limit+in+Bytes]
> deprecated the constructor to {{FetchRequest}} which shuffles the
> {{requestInfo}} parameter, in favor of round robin reordering logic added to
> the replica fetcher and the consumer API. However, this was not added to the
> old consumer {{ConsumerFetcherThread}}, which has resulted in unfair
> partition fetching since 0.10.1.
> In order to maintain the old consumer, we need to add the removed shuffle to
> {{buildFetchRequest}} as the topic-partition list for each {{FetchRequest}}
> is composed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
