[ https://issues.apache.org/jira/browse/KAFKA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978846#comment-15978846 ]
ASF GitHub Bot commented on KAFKA-4928: --------------------------------------- GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2889 KAFKA-4928: Add integration test for DumpLogSegments Adding tests for `kafka.tools.DumpLogSegments` You can merge this pull request into a Git repository by running: $ git pull https://github.com/original-brownbear/kafka KAFKA-4928 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2889.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2889 ---- ---- > Add integration test for DumpLogSegments > ---------------------------------------- > > Key: KAFKA-4928 > URL: https://issues.apache.org/jira/browse/KAFKA-4928 > Project: Kafka > Issue Type: Test > Reporter: Ismael Juma > Assignee: Armin Braun > Labels: newbie > Fix For: 0.11.0.0 > > > DumpLogSegments is an important tool to analyse log files, but we have no > JUnit tests for it. It would be good to have some tests that verify that the > output is sane for a populated log. > Our system tests call DumpLogSegments, but we should be able to detect > regressions via the JUnit test suite. -- This message was sent by Atlassian JIRA (v6.3.15#6346)