[
https://issues.apache.org/jira/browse/KAFKA-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983038#comment-15983038
]
ASF GitHub Bot commented on KAFKA-4942:
---------------------------------------
GitHub user 56quarters opened a pull request:
https://github.com/apache/kafka/pull/2912
KAFKA-4942 Fix commitTimeoutMs being set before the commit actually started
This fixes KAFKA-4942
This supersededs #2730
/cc @simplesteph @gwenshap @ewencp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarter-travel-media/kafka
fix-connect-offset-commit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2912
----
commit f93bd001a723c5e1402bf92474f43fb0b991a44c
Author: simplesteph <[email protected]>
Date: 2017-03-24T00:03:07Z
Fixed commitTimeoutMs being set before the commit actually started
Fixes KAFKA-4942
commit e7b704d97b8de35384f6d24ba48f050a0b20be01
Author: Nick Pillitteri <[email protected]>
Date: 2017-04-21T19:49:37Z
Test for commitTimeoutMs being set before commit started
See KAFKA-4942
----
> Kafka Connect: Offset committing times out before expected
> ----------------------------------------------------------
>
> Key: KAFKA-4942
> URL: https://issues.apache.org/jira/browse/KAFKA-4942
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 0.10.2.0
> Reporter: Stephane Maarek
>
> On Kafka 0.10.2.0
> I run a connector that deals with a lot of data, in a kafka connect cluster
> When the offsets are getting committed, I get the following:
> {code}
> [2017-03-23 03:56:25,134] INFO WorkerSinkTask{id=MyConnector-1} Committing
> offsets (org.apache.kafka.connect.runtime.WorkerSinkTask)
> [2017-03-23 03:56:25,135] WARN Commit of WorkerSinkTask{id=MyConnector-1}
> offsets timed out (org.apache.kafka.connect.runtime.WorkerSinkTask)
> {code}
> If you look at the timestamps, they're 1 ms apart. My settings are the
> following:
> {code}
> offset.flush.interval.ms = 120000
> offset.flush.timeout.ms = 60000
> offset.storage.topic = _connect_offsets
> {code}
> It seems the offset flush timeout setting is completely ignored for the look
> of the logs. I would expect the timeout message to happen 60 seconds after
> the commit offset INFO message, not 1 millisecond later.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
