Hi All, This is all committed now.
There are a few minor changes that had to be made, due to Java 8 features not yet able to use, awaiting KIP-118. • Header static interface method: “static Header create(String key, byte[] value)” o This required java8 as interface static method o Jason proposed a replacement solution which we have implemented - new method in Headers class: “Headers add(String key, byte[] value)” o I think we will look to keep this, as after implementing it seems a cleaner solution anyhow. (KIP will be updated to reflect) o New method, serves same purpose and allows users to create a new header, without the need to have concrete implementation exposed • Added ExtendedSerializer/Deserializer instead of adding new default method to existing interfaces o Work around due to lack of Java8 o We hope to remove this new class’s as soon as KIP-118 is implemented. There is some outstanding work noted to be done, this will be in a subsequent PR. • If KIP-118 completes - revert back in Java 8 optimisations and remove some of the workarounds mentioned above. • Update upgrade.html docs I would like to take the opportunity, to thank everyone who participated in the KIP discussion and vote over the past 7 months. And in particular I would like to thank Jason especially for taking on the protocol changes for me ☺ Radai, Jiangjie, Ismael as well for the time and effort in reviewing the code and providing vital feedback. Lastly a plug for my next KIP ;) – please see KIP-145. Thanks to all, Mike From: Michael Pearce <michael.pea...@ig.com> Date: Friday, 31 March 2017 at 23:19 To: "dev@kafka.apache.org" <dev@kafka.apache.org> Subject: KIP-82 Record Headers Update Hi All, PR to add the client api building on the protocol changes already in trunk/master is raised in GitHub https://github.com/apache/kafka/pull/2772 Thanks Jeroen for feedback already :). Please note we have dropped Java 8 bits for now and replaced with Java 7 compatible until KIP-118 is completed. If KIP-118 completes I will update with further commits/pr. Cheers Mike The information contained in this email is strictly confidential and for the use of the addressee only, unless otherwise indicated. If you are not the intended recipient, please do not read, copy, use or disclose to others this message or any attachment. Please also notify the sender by replying to this email or by telephone (+44(020 7896 0011) and then delete the email and any copies of it. Opinions, conclusion (etc) that do not relate to the official business of this company shall be understood as neither given nor endorsed by it. IG is a trading name of IG Markets Limited (a company registered in England and Wales, company number 04008957) and IG Index Limited (a company registered in England and Wales, company number 01190902). Registered address at Cannon Bridge House, 25 Dowgate Hill, London EC4R 2YA. Both IG Markets Limited (register number 195355) and IG Index Limited (register number 114059) are authorised and regulated by the Financial Conduct Authority.
