[ 
https://issues.apache.org/jira/browse/KAFKA-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990377#comment-15990377
 ] 

ASF GitHub Bot commented on KAFKA-5055:
---------------------------------------

GitHub user dpoldrugo opened a pull request:

    https://github.com/apache/kafka/pull/2949

    KAFKA-5055: Kafka Streams skipped-records-rate sensor bug

    Fix as described in the [KAFKA-5055 Jira 
comment](https://issues.apache.org/jira/browse/KAFKA-5055?focusedCommentId=15990086&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15990086).
    
    @mjsax @guozhangwang take a look

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpoldrugo/kafka 
KAFKA-5055-skipped-records-rate-sensor-bug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2949
    
----
commit a8768f4f4431c84880bec617f9c91b866fc003c7
Author: dpoldrugo <[email protected]>
Date:   2017-04-30T20:48:36Z

    KAFKA-5055 Kafka Streams skipped-records-rate sensor bug

----


> Kafka Streams skipped-records-rate sensor producing nonzero values even when 
> FailOnInvalidTimestamp is used as extractor
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5055
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5055
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Nikki Thean
>            Assignee: Guozhang Wang
>
> According to the code and the documentation for this metric, the only reason 
> for a skipped record is an invalid timestamp, except that a) I am reading 
> from a topic that is populated solely by Kafka Connect and b) I am using 
> `FailOnInvalidTimestamp` as the timestamp extractor.
> Either I'm missing something in the documentation (i.e. another reason for 
> skipped records) or there is a bug in the code that calculates this metric.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to