Jeyhun, thanks a lot for the KIP!
I think there are two issues we need to address: (1) The KIP does not consider backward compatibility. Users did complain about this in past releases already, and as the user base grows, we should not break backward compatibility in future releases anymore. Thus, we should think of a better way to allow key access. Mathieu's comment goes into the same direction >> On the other hand, the number of compile failures that would need to be >> fixed from this change is unfortunate. :-) (2) Another concern is, that there is no guard to prevent user code to modify the key. This might corrupt partitioning if users do alter the key (accidentally -- or users are just not aware that they are not allowed to modify the provided key object) and thus break the application. (This was the original motivation to not provide the key in the first place -- it's guards against modification.) -Matthias On 5/1/17 6:31 AM, Mathieu Fenniak wrote: > Hi Jeyhun, > > I just want to add my voice that, I too, have wished for access to the > record key during a mapValues or similar operation. > > On the other hand, the number of compile failures that would need to be > fixed from this change is unfortunate. :-) But at least it would all be a > pretty clear and easy change. > > Mathieu > > > On Mon, May 1, 2017 at 6:55 AM, Jeyhun Karimov <je.kari...@gmail.com> wrote: > >> Dear community, >> >> I want to share KIP-149 [1] based on issues KAFKA-4218 [2], KAFKA-4726 [3], >> KAFKA-3745 [4]. The related PR can be found at [5]. >> I would like to get your comments. >> >> [1] >> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> 149%3A+Enabling+key+access+in+ValueTransformer%2C+ >> ValueMapper%2C+and+ValueJoiner >> [2] https://issues.apache.org/jira/browse/KAFKA-4218 >> [3] https://issues.apache.org/jira/browse/KAFKA-4726 >> [4] https://issues.apache.org/jira/browse/KAFKA-3745 >> [5] https://github.com/apache/kafka/pull/2946 >> >> >> Cheers, >> Jeyhun >> >> >> >> -- >> -Cheers >> >> Jeyhun >> >
signature.asc
Description: OpenPGP digital signature
