[ https://issues.apache.org/jira/browse/KAFKA-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998530#comment-15998530 ]
ASF GitHub Bot commented on KAFKA-5135: --------------------------------------- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/2983 KAFKA-5135: Controller Health Metrics (KIP-143) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-5135-controller-health-metrics-kip-143 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2983.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2983 ---- commit 2b5431f35c1b4d8fe6590d25565e339948d9f43f Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T13:06:08Z Refactor BrokerTopicStats and ControllerStats so that they are classes This removes the need to force object initialisation via hacks to register the relevant metrics during start-up. commit 3edaabfca5eac806cdf4d8f8e84463f7573e0eaa Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T13:47:58Z Add timer metrics commit e6e3270e0621a61363743eb2a108190b8ec9196c Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T13:48:11Z Code clean-ups commit 9b99aacafec40b0ba605ccb34d4fd3f9d7ae1298 Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T15:46:03Z Add controller state metric commit 7d6e840c6efe9c103443d7d705169ee9038179e9 Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T15:46:44Z Use volatile variables instead of `AtomicInteger` and other clean-ups We don’t use any functionality from `AtomicInteger`, we simply set and read values. commit bc393781bf367561e723dd472e39b9a3373e5963 Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T16:02:05Z Add ControllerChannelManager queue size metrics commit f609906454d80059d4f8a41fe2010f7ecaf542cd Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-05-05T16:29:20Z Add FailedIsrUpdatesPerSec metric ---- > Controller Health Metrics (KIP-143) > ----------------------------------- > > Key: KAFKA-5135 > URL: https://issues.apache.org/jira/browse/KAFKA-5135 > Project: Kafka > Issue Type: Bug > Reporter: Ismael Juma > Assignee: Ismael Juma > Fix For: 0.11.0.0 > > > Ensuring that the Kafka Controller is healthy is an important part of > monitoring the health of a Kafka Cluster. However, the metrics currently > exposed are not sufficient for reliably detecting issues like slow progress > or deadlocks. We propose a few new metrics that will solve this issue. Even > though KAFKA-5028 will potentially fix existing deadlocks, there will still > be known (and potentially unknown) issues that can cause slow or no progress > so these metrics will still be useful. > KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-143%3A+Controller+Health+Metrics -- This message was sent by Atlassian JIRA (v6.3.15#6346)