[
https://issues.apache.org/jira/browse/KAFKA-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001621#comment-16001621
]
ASF GitHub Bot commented on KAFKA-5198:
---------------------------------------
GitHub user cmccabe opened a pull request:
https://github.com/apache/kafka/pull/3000
KAFKA-5198. RocksDbStore#openIterators should be synchronized, since …
…it is accessed from multiple threads
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmccabe/kafka KAFKA-5198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3000.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3000
----
commit a1216d4e9e59028bf2827f91f6e8feb9459b44be
Author: Colin P. Mccabe <[email protected]>
Date: 2017-05-08T21:53:48Z
KAFKA-5198. RocksDbStore#openIterators should be synchronized, since it is
accessed from multiple threads
----
> RocksDbStore#openIterators should be synchronized, since it is accessed from
> multiple threads
> ---------------------------------------------------------------------------------------------
>
> Key: KAFKA-5198
> URL: https://issues.apache.org/jira/browse/KAFKA-5198
> Project: Kafka
> Issue Type: Bug
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
>
> Currently, {{RocksDBIterator#close}} accesses {{RocksDbStore#openIterators}}
> without taking the {{RocksDbStore}} lock. The only lock
> {{RocksDBIterator#close}} holds is a lock on the iterator object, which does
> not help here. So {{RocksDbStore#openIterators}} should be made
> synchronized. Otherwise there is undefined behavior, including
> {{ConcurrentModificationExceptions}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
