[ https://issues.apache.org/jira/browse/KAFKA-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004675#comment-16004675 ]
Edoardo Comar commented on KAFKA-4982: -------------------------------------- The implementation took the slight deviation from the KIP screenshots of adding the {{listener}} tag only if it differs from {{protocol}}. We should have taken this decision while discussing the KIP. Opinions? > Add listener tag to socket-server-metrics.connection-... metrics > ------------------------------------------------------------------ > > Key: KAFKA-4982 > URL: https://issues.apache.org/jira/browse/KAFKA-4982 > Project: Kafka > Issue Type: Improvement > Reporter: Edoardo Comar > Assignee: Edoardo Comar > Fix For: 0.11.0.0 > > > Metrics in socket-server-metrics like connection-count connection-close-rate > etc are tagged with networkProcessor:<id> > where the id of a network processor is just a numeric integer. > If you have more than one listener (eg PLAINTEXT, SASL_SSL, etc.), the id > just keeps incrementing and when looking at the metrics it is hard to match > the metric tag to a listener. > You need to know the number of network threads and the order in which the > listeners are declared in the brokers' server.properties. > We should add a tag showing the listener label, that would also make it much > easier to group the metrics in a tool like grafana -- This message was sent by Atlassian JIRA (v6.3.15#6346)