[ https://issues.apache.org/jira/browse/KAFKA-5244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010821#comment-16010821 ]
Ismael Juma commented on KAFKA-5244: ------------------------------------ If you think the change makes sense, I could create a separate PR for it, it's the first commit in the PR: https://github.com/apache/kafka/pull/2983/commits/9896bf99c66547fabad31ca53d89962d3a6f526a > Tests which delete singleton metrics break subsequent metrics tests > ------------------------------------------------------------------- > > Key: KAFKA-5244 > URL: https://issues.apache.org/jira/browse/KAFKA-5244 > Project: Kafka > Issue Type: Bug > Components: core > Reporter: Rajini Sivaram > Assignee: Rajini Sivaram > Fix For: 0.11.0.0 > > > Static metrics like {{BrokerTopicStats.ReplicationBytesInPerSec}} are created > in a singleton, resulting in one metric being created in a JVM. Some tests > like {{MetricsDuringTopicCreationDeletionTest}} delete all metrics from the > static metrics registry. The singleton metrics don't get recreated and > subsequent tests relying on these metrics may fail. > Singleton metrics make testing hard - we have no idea what metrics are being > tested. Not sure we want to change that though since there is a lot of code > that relies on this. But we have to fix tests to ensure that metrics are left > in a good state. -- This message was sent by Atlassian JIRA (v6.3.15#6346)