[
https://issues.apache.org/jira/browse/KAFKA-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017475#comment-16017475
]
Jorge Quilcate commented on KAFKA-5266:
---------------------------------------
[~hachikuji] some comments about the improvements:
1. Agree, it will be fixed for the following cases: `resetToOffset`,
`resetFromFile` and `resetShiftBy`; as in the other cases, offsets are gathered
from the log, not by input.
2. Agree.
3. This option was kept to support the following case: export current offsets,
and use it later to go back to an specific point in time. I think this scenario
is usable enough to maintain it.
4. This looks OK, but I'm not sure if I get where this could happen. Could you
point where this is possible?
> Follow-up improvements for consumer offset reset tool (KIP-122)
> ---------------------------------------------------------------
>
> Key: KAFKA-5266
> URL: https://issues.apache.org/jira/browse/KAFKA-5266
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Jason Gustafson
> Assignee: Jorge Quilcate
> Fix For: 0.11.0.0
>
>
> 1. We should try to ensure that offsets are in range for the topic partition.
> We currently only verify this for the shift option.
> 2. If you provide a CSV file, you shouldn't need to specify one of the
> --all-topics or --topic options.
> 3. We currently support a "reset to current offsets" option if none of the
> supported reset options are provided. This seems kind of useless. Perhaps we
> should just enforce that one of the reset options is provided.
> 4. The command fails with an NPE if we cannot find one of the offsets we are
> trying to reset. It would be better to raise an exception with a friendlier
> message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
