[
https://issues.apache.org/jira/browse/KAFKA-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021565#comment-16021565
]
ASF GitHub Bot commented on KAFKA-5282:
---------------------------------------
GitHub user vahidhashemian opened a pull request:
https://github.com/apache/kafka/pull/3129
KAFKA-5282: Use a factory method to create producers and consumers an d
close them in tearDown
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka KAFKA-5282
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3129
----
commit 260979422071a03c4fef25493c3909f387513a5f
Author: Vahid Hashemian <[email protected]>
Date: 2017-05-23T18:05:31Z
KAFKA-5282: Use a factory method to create producers and consumers and
close them in tearDown
----
> Transactions integration test: Use factory methods to keep track of open
> producers and consumers and close them all on tearDown
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-5282
> URL: https://issues.apache.org/jira/browse/KAFKA-5282
> Project: Kafka
> Issue Type: Sub-task
> Components: clients, core, producer
> Reporter: Apurva Mehta
> Assignee: Vahid Hashemian
> Labels: exactly-once
> Fix For: 0.11.0.0
>
>
> See: https://github.com/apache/kafka/pull/3093/files#r117354588
> The current transactions integration test creates individual producers and
> consumer per test, and closes them independently.
> It would be more robust to create them through a central factory method that
> keeps track of each instance, and then close those instances on `tearDown`.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
