[ https://issues.apache.org/jira/browse/KAFKA-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027616#comment-16027616 ]
Jun Rao commented on KAFKA-4340: -------------------------------- [~edenhill], I wasn't suggesting that this commit is a breaking change. In fact, it gives the user the same current behavior if log.message.timestamp.difference.max.ms is explicitly set to log.retention.ms. I am just saying that the current behavior of rejecting the whole batch w/o telling the clients the violating messages can be improved, which may need a separate KIP. So, I am not sure if we need to revert this commit since it avoids unnecessary log rolling. > Change the default value of log.message.timestamp.difference.max.ms to the > same as log.retention.ms > --------------------------------------------------------------------------------------------------- > > Key: KAFKA-4340 > URL: https://issues.apache.org/jira/browse/KAFKA-4340 > Project: Kafka > Issue Type: Improvement > Components: core > Affects Versions: 0.10.1.0 > Reporter: Jiangjie Qin > Assignee: Jiangjie Qin > Fix For: 0.11.0.0 > > > [~junrao] brought up the following scenario: > If users are pumping data with timestamp already passed log.retention.ms into > Kafka, the messages will be appended to the log but will be immediately > rolled out by log retention thread when it kicks in and the messages will be > deleted. > To avoid this produce-and-deleted scenario, we can set the default value of > log.message.timestamp.difference.max.ms to be the same as log.retention.ms. -- This message was sent by Atlassian JIRA (v6.3.15#6346)