[
https://issues.apache.org/jira/browse/KAFKA-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045695#comment-16045695
]
ASF GitHub Bot commented on KAFKA-3123:
---------------------------------------
GitHub user mimaison opened a pull request:
https://github.com/apache/kafka/pull/3296
KAFKA-3123: Follower Broker cannot start if offsets are already out o…
…f range
From https://github.com/apache/kafka/pull/1716#discussion_r112000498,
ensure the cleaner is restarted if Log.truncateTo throws
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mimaison/kafka KAFKA-3123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3296
----
commit e12690320d68c7686ecf9ceebe53a4498b8a5f0d
Author: Mickael Maison <[email protected]>
Date: 2017-06-10T18:49:43Z
KAFKA-3123: Follower Broker cannot start if offsets are already out of range
----
> Follower Broker cannot start if offsets are already out of range
> ----------------------------------------------------------------
>
> Key: KAFKA-3123
> URL: https://issues.apache.org/jira/browse/KAFKA-3123
> Project: Kafka
> Issue Type: Bug
> Components: core, replication
> Affects Versions: 0.9.0.0
> Reporter: Soumyajit Sahu
> Assignee: Soumyajit Sahu
> Priority: Critical
> Labels: patch
> Fix For: 0.11.0.1
>
> Attachments:
> 0001-Fix-Follower-crashes-when-offset-out-of-range-during.patch
>
>
> I was trying to upgrade our test Windows cluster from 0.8.1.1 to 0.9.0 one
> machine at a time. Our logs have just 2 hours of retention. I had re-imaged
> the test machine under consideration, and got the following error in loop
> after starting afresh with 0.9.0 broker:
> [2016-01-19 13:57:28,809] WARN [ReplicaFetcherThread-1-169595708], Replica
> 177775588 for partition [EventLogs4,1] reset its fetch offset from 0 to
> current leader 169595708's start offset 334086
> (kafka.server.ReplicaFetcherThread)
> [2016-01-19 13:57:28,809] ERROR [ReplicaFetcherThread-1-169595708], Error
> getting offset for partition [EventLogs4,1] to broker 169595708
> (kafka.server.ReplicaFetcherThread)
> java.lang.IllegalStateException: Compaction for partition [EXO_EventLogs4,1]
> cannot be aborted and paused since it is in LogCleaningPaused state.
> at
> kafka.log.LogCleanerManager$$anonfun$abortAndPauseCleaning$1.apply$mcV$sp(LogCleanerManager.scala:149)
> at
> kafka.log.LogCleanerManager$$anonfun$abortAndPauseCleaning$1.apply(LogCleanerManager.scala:140)
> at
> kafka.log.LogCleanerManager$$anonfun$abortAndPauseCleaning$1.apply(LogCleanerManager.scala:140)
> at kafka.utils.CoreUtils$.inLock(CoreUtils.scala:262)
> at
> kafka.log.LogCleanerManager.abortAndPauseCleaning(LogCleanerManager.scala:140)
> at kafka.log.LogCleaner.abortAndPauseCleaning(LogCleaner.scala:141)
> at kafka.log.LogManager.truncateFullyAndStartAt(LogManager.scala:304)
> at
> kafka.server.ReplicaFetcherThread.handleOffsetOutOfRange(ReplicaFetcherThread.scala:185)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1$$anonfun$apply$2.apply(AbstractFetcherThread.scala:152)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1$$anonfun$apply$2.apply(AbstractFetcherThread.scala:122)
> at scala.Option.foreach(Option.scala:236)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1.apply(AbstractFetcherThread.scala:122)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2$$anonfun$apply$mcV$sp$1.apply(AbstractFetcherThread.scala:120)
> at
> scala.collection.mutable.HashMap$$anonfun$foreach$1.apply(HashMap.scala:98)
> at
> scala.collection.mutable.HashMap$$anonfun$foreach$1.apply(HashMap.scala:98)
> at
> scala.collection.mutable.HashTable$class.foreachEntry(HashTable.scala:226)
> at scala.collection.mutable.HashMap.foreachEntry(HashMap.scala:39)
> at scala.collection.mutable.HashMap.foreach(HashMap.scala:98)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2.apply$mcV$sp(AbstractFetcherThread.scala:120)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2.apply(AbstractFetcherThread.scala:120)
> at
> kafka.server.AbstractFetcherThread$$anonfun$processFetchRequest$2.apply(AbstractFetcherThread.scala:120)
> at kafka.utils.CoreUtils$.inLock(CoreUtils.scala:262)
> at
> kafka.server.AbstractFetcherThread.processFetchRequest(AbstractFetcherThread.scala:118)
> at
> kafka.server.AbstractFetcherThread.doWork(AbstractFetcherThread.scala:93)
> at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:63)
> I could unblock myself with a code change. I deleted the action for "case s
> =>" in the LogCleanerManager.scala's abortAndPauseCleaning(). I think we
> should not throw exception if the state is already LogCleaningAborted or
> LogCleaningPaused in this function, but instead just let it roll.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
