GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/3447
MINOR: Do not wait for first line of console consumer output since we now
have a more reliable test using JMX
Waiting for the first line of output was added in KAFKA-2527 when JmxMixin
was originally added as a heuristic to
determine when the process was ready. We've since determined this is not
good enough given JmxTool's limitations
and now include a separate, more reliable check before starting JmxTool.
This check is also dangerous since a
consumer that is started before data is available in the topic, it won't
output anything to stdout and only logs
errors to a separate log file. This means we may have a long delay between
starting the process and starting JMX
monitoring.
Since we have a more reliable check for liveness via JMX now (and in cases
that need it, partition assignment
metrics via JMX), we should no longer need to wait for the first line of
output.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka
dont-wait-first-line-console-consumer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3447
----
commit 6226de19066362f2fe86a74d6490307e0c6dcef4
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2017-06-27T22:48:41Z
MINOR: Do not wait for first line of console consumer output since we now
have a more reliable test using JMX
Waiting for the first line of output was added in KAFKA-2527 when JmxMixin
was originally added as a heuristic to
determine when the process was ready. We've since determined this is not
good enough given JmxTool's limitations
and now include a separate, more reliable check before starting JmxTool.
This check is also dangerous since a
consumer that is started before data is available in the topic, it won't
output anything to stdout and only logs
errors to a separate log file. This means we may have a long delay between
starting the process and starting JMX
monitoring.
Since we have a more reliable check for liveness via JMX now (and in cases
that need it, partition assignment
metrics via JMX), we should no longer need to wait for the first line of
output.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
