Hi Matthias,

the KIP-176 is for removing so not having --new-consumer anymore.

What you are speaking about, I guess, is the deprecated step that isn't 
addressed by the KIP.

I already have a PR for deprecation https://github.com/apache/kafka/pull/3537 
which is addressed in the way you are talking about :-)


I hope to have a review on that PR soon for the merge ;)


Thanks.


Paolo Patierno
Senior Software Engineer (IoT) @ Red Hat
Microsoft MVP on Windows Embedded & IoT
Microsoft Azure Advisor

Twitter : @ppatierno<http://twitter.com/ppatierno>
Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
Blog : DevExperience<http://paolopatierno.wordpress.com/>


________________________________
From: Matthias J. Sax <matth...@confluent.io>
Sent: Monday, July 17, 2017 5:11 PM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-176: Remove deprecated new-consumer option in 
ConsoleConsumer tool

Hi,

I agree that the option can be removed/deprecated.

However, I don't understand this:

> there will be no check that the new-consumer option is an invalid argument 
> with the old consumer.

I thinks, for backward compatibility, this check should be there. The
only change should be, that if `--bootstrap-servers` is used, one can
omit `--new-consumer` (and if used, as warning is printed).


-Matthias

On 7/17/17 6:30 AM, Paolo Patierno wrote:
> Hi dev,
>
> I'd like to discuss the possibility to remove the new-consumer option in the 
> ConsoleConsumer tool.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-176%3A+Remove+deprecated+new-consumer+option+in+ConsoleConsumer+tool
>
>
> I have already opened a JIRA with related PR for marking it as deprecated in 
> the next release (https://issues.apache.org/jira/browse/KAFKA-5599) as 
> suggested by Ismael Juma.
>
> The next step should be to vote/accept the KIP and removing the option from 
> the tool in the subsequent release cycle.
>
>
> Thanks,
>
>
> Paolo Patierno
> Senior Software Engineer (IoT) @ Red Hat
> Microsoft MVP on Microsoft Azure IoT
> Microsoft Azure Advisor
>
> Twitter : @ppatierno<http://twitter.com/ppatierno>
> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> Blog : DevExperience<http://paolopatierno.wordpress.com/>
>

Reply via email to