Hi Tom, Thanks for the KIP, it's a useful one. I find the proposed method name `electPreferredReplicaLeader` a little hard to read. It seems that a small change would make it clearer: `electPreferredReplicaAsLeader`. The next point is that this is a batch API, so it should ideally be plural like the other AdminClient methods. Maybe `electPreferredReplicasAsLeaders`, but that's quite a mouthful. Maybe we should shorten it to `electPreferredLeaders`. Thoughts?
Ismael On Wed, Aug 2, 2017 at 6:34 PM, Tom Bentley <t.j.bent...@gmail.com> wrote: > In a similar vein to KIP-179 I've created KIP-183 ( > https://cwiki.apache.org/confluence/display/KAFKA/KIP-183+-+Change+ > PreferredReplicaLeaderElectionCommand+to+use+AdminClient) > which is about deprecating the --zookeeper option to > kafka-preferred-replica-election.sh and replacing it with an option which > would use a new AdminClient-based API. > > As it stands the KIP is focussed on simply moving the existing > functionality behind the AdminClient. > > I'd be grateful for any feedback people may have on this. > > Thanks, > > Tom >
