Thanks for the explanation. SecurityProtocol was declared public in previous releases, hence I didn't notice that it is internal.
On Thu, Oct 12, 2017 at 4:07 PM, Guozhang Wang <wangg...@gmail.com> wrote: > For internal classes that are designed to be abstracted away from normal > users, I think it is OK to not mention it in the upgrade guides. > > For developers rather than users of Kafka, they are assumed to be familiar > with the codebase and not only rely on upgrade guide docs for such > information. > > > Guozhang > > On Thu, Oct 12, 2017 at 2:58 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > bq. Internal classes which had previously been located in this package > have > > been moved elsewhere > > > > It would be clearer to Kafka users if the relocation of > > org.apache.kafka.common.protocol.SecurityProtocol is mentioned > explicitly. > > Otherwise they need to dig into the code to find out. > > > > Just my two cents. > > > > On Thu, Oct 12, 2017 at 2:24 PM, Guozhang Wang <wangg...@gmail.com> > wrote: > > > > > Ted, > > > > > > I can found that we do have a corresponding doc change for this > renaming: > > > > > > https://github.com/apache/kafka/pull/3863/files#diff- > > > 8100f2416b657c1e1e4238dabf8a15e0 > > > > > > And from the web docs: > > > > > > http://home.apache.org/~guozhang/kafka-1.0.0-rc0/ > > > kafka_2.11-1.0.0-site-docs.tgz > > > > > > I can indeed find it in the upgrade.html. > > > > > > > > > Guozhang > > > > > > > > > On Thu, Oct 12, 2017 at 11:39 AM, Guozhang Wang <wangg...@gmail.com> > > > wrote: > > > > > > > Thanks Ted, > > > > > > > > I'm looking into this for possible doc changes now. > > > > > > > > Guozhang > > > > > > > > On Wed, Oct 11, 2017 at 3:23 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > > > >> Looks like the following change is needed for some downstream > project > > to > > > >> compile their code (which was using 0.11.0.1): > > > >> > > > >> -import org.apache.kafka.common.protocol.SecurityProtocol; > > > >> +import org.apache.kafka.common.security.auth.SecurityProtocol; > > > >> > > > >> I took a look at docs/upgrade.html but didn't see any mentioning. > > > >> > > > >> Should this be documented ? > > > >> > > > >> On Tue, Oct 10, 2017 at 6:34 PM, Guozhang Wang <wangg...@gmail.com> > > > >> wrote: > > > >> > > > >> > Hello Kafka users, developers and client-developers, > > > >> > > > > >> > This is the first candidate for release of Apache Kafka 1.0.0. > > > >> > > > > >> > It's worth noting that starting in this version we are using a > > > different > > > >> > version protocol with three digits: *major.minor.bug-fix* > > > >> > > > > >> > Any and all testing is welcome, but the following areas are worth > > > >> > highlighting: > > > >> > > > > >> > 1. Client developers should verify that their clients can > > > >> produce/consume > > > >> > to/from 1.0.0 brokers (ideally with compressed and uncompressed > > data). > > > >> > 2. Performance and stress testing. Heroku and LinkedIn have helped > > > with > > > >> > this in the past (and issues have been found and fixed). > > > >> > 3. End users can verify that their apps work correctly with the > new > > > >> > release. > > > >> > > > > >> > This is a major version release of Apache Kafka. It includes 29 > new > > > >> KIPs. > > > >> > See the release notes and release plan > > > >> > (*https://cwiki.apache.org/confluence/pages/viewpage. > > > >> > action?pageId=71764913 > > > >> > <https://cwiki.apache.org/confluence/pages/viewpage.action? > > > >> pageId=71764913 > > > >> > >*) > > > >> > for more details. A few feature highlights: > > > >> > > > > >> > * Java 9 support with significantly faster TLS and CRC32C > > > >> implementations > > > >> > (KIP) > > > >> > * JBOD improvements: disk failure only disables failed disk but > not > > > the > > > >> > broker (KIP-112/KIP-113) > > > >> > * Newly added metrics across all the modules (KIP-164, KIP-168, > > > KIP-187, > > > >> > KIP-188, KIP-196) > > > >> > * Kafka Streams API improvements (KIP-120 / 130 / 138 / 150 / 160 > / > > > >> 161), > > > >> > and drop compatibility "Evolving" annotations > > > >> > > > > >> > Release notes for the 1.0.0 release: > > > >> > *http://home.apache.org/~guozhang/kafka-1.0.0-rc0/ > > RELEASE_NOTES.html > > > >> > <http://home.apache.org/~guozhang/kafka-1.0.0-rc0/ > > RELEASE_NOTES.html > > > >* > > > >> > > > > >> > > > > >> > > > > >> > *** Please download, test and vote by Friday, October 13, 8pm PT > > > >> > > > > >> > Kafka's KEYS file containing PGP keys we use to sign the release: > > > >> > http://kafka.apache.org/KEYS > > > >> > > > > >> > * Release artifacts to be voted upon (source and binary): > > > >> > *http://home.apache.org/~guozhang/kafka-1.0.0-rc0/ > > > >> > <http://home.apache.org/~guozhang/kafka-1.0.0-rc0/>* > > > >> > > > > >> > * Maven artifacts to be voted upon: > > > >> > https://repository.apache.org/content/groups/staging/ > > > >> > > > > >> > * Javadoc: > > > >> > *http://home.apache.org/~guozhang/kafka-1.0.0-rc0/javadoc/ > > > >> > <http://home.apache.org/~guozhang/kafka-1.0.0-rc0/javadoc/>* > > > >> > > > > >> > * Tag to be voted upon (off 1.0 branch) is the 1.0.0-rc0 tag: > > > >> > > > > >> > https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=tag;h= > > > >> > 2f97bc6a9ee269bf90b019e50b4eeb43df2f1143 > > > >> > > > > >> > * Documentation: > > > >> > Note the documentation can't be pushed live due to changes that > will > > > >> not go > > > >> > live until the release. You can manually verify by downloading > > > >> > http://home.apache.org/~guozhang/kafka-1.0.0-rc0/ > > > >> > kafka_2.11-1.0.0-site-docs.tgz > > > >> > > > > >> > * Successful Jenkins builds for the 1.0.0 branch: > > > >> > Unit/integration tests: https://builds.apache.org/job/ > > > >> kafka-1.0-jdk7/20/ > > > >> > > > > >> > > > > >> > /************************************** > > > >> > > > > >> > > > > >> > Thanks, > > > >> > -- Guozhang > > > >> > > > > >> > > > > > > > > > > > > > > > > -- > > > > -- Guozhang > > > > > > > > > > > > > > > > -- > > > -- Guozhang > > > > > > > > > -- > -- Guozhang >
