It's fine to be more detailed, but ConfigException is already implied for all other config issues as well.
Default could be either null or just empty string. re: alternatives, if you wanted to be slightly more detailed (though still a bit vague) re: supported syntax, you could just say that while Pattern is used, we only guarantee support for common regular expression syntax. Not sure if there's a good way of defining what "common" syntax is. Otherwise LGTM, and thanks for helping fill in a longstanding gap! -Ewen On Thu, Oct 26, 2017 at 7:56 PM, Ted Yu <yuzhih...@gmail.com> wrote: > bq. Users may specify only one of 'topics' or 'topics.pattern'. > > Can you fill in which exception would be thrown if both of them are > specified > ? > > Cheers > > On Thu, Oct 26, 2017 at 6:27 PM, Jeff Klukas <j...@klukas.net> wrote: > > > Looking for feedback on > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 215%3A+Add+topic+regex+support+for+Connect+sinks > > >
