Nice addition! +1 (non-binding)
Konstantine On Fri, Nov 3, 2017 at 4:52 PM, Jeff Klukas <jklu...@simple.com> wrote: > So sorry for skirting the process there. I wasn't aware of the 72 hour > window and I don't see that mentioned in in > https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Voting > > Should I feel free to update that wiki page with a note about the window? > > On Fri, Nov 3, 2017 at 7:49 PM, Ewen Cheslack-Postava <e...@confluent.io> > wrote: > > > Jeff, > > > > Just FYI re: process, I think you're pretty much definitely in the clear > > hear since this one is a straightforward design I doubt anybody would > > object to, but voting normally stays open 72h to ensure everyone has a > > chance to weigh in. > > > > Again thanks for the KIP and we can move any final discussion over to the > > PR! > > > > -Ewen > > > > On Fri, Nov 3, 2017 at 4:43 PM, Jeff Klukas <jklu...@simple.com> wrote: > > > > > Looks like we've achieved lazy majority, so I'll move the KIP to > > approved. > > > > > > Thanks all for looking this over. > > > > > > On Fri, Nov 3, 2017 at 7:31 PM, Jason Gustafson <ja...@confluent.io> > > > wrote: > > > > > > > +1. Thanks for the KIP! > > > > > > > > On Fri, Nov 3, 2017 at 2:15 PM, Guozhang Wang <wangg...@gmail.com> > > > wrote: > > > > > > > > > +1 binding > > > > > > > > > > On Fri, Nov 3, 2017 at 1:25 PM, Ewen Cheslack-Postava < > > > e...@confluent.io > > > > > > > > > > wrote: > > > > > > > > > > > +1 binding > > > > > > > > > > > > Thanks Jeff! > > > > > > > > > > > > On Wed, Nov 1, 2017 at 5:21 PM, Randall Hauch <rha...@gmail.com> > > > > wrote: > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > Thanks for pushing this through. Great work! > > > > > > > > > > > > > > Randall Hauch > > > > > > > > > > > > > > On Wed, Nov 1, 2017 at 9:40 AM, Jeff Klukas < > jklu...@simple.com> > > > > > wrote: > > > > > > > > > > > > > > > I haven't heard any additional concerns over the proposal, so > > I'd > > > > > like > > > > > > to > > > > > > > > get the voting process started for: > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > > > 215%3A+Add+topic+regex+support+for+Connect+sinks > > > > > > > > > > > > > > > > It adds a topics.regex option for Kafka Connect sinks as an > > > > > alternative > > > > > > > to > > > > > > > > the existing required topics option. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > -- Guozhang > > > > > > > > > > > > > > >
