Hi, Hu, Thanks for the KIP. Looks good overall. Could you document the mbean name for the new metrics? We probably want the name to be consistent with records-max-lag as described in http://kafka.apache.org/documentation/#monitoring. Also, it seems that records-lead-avg and records-lead-min don't need the partition prefix since they are aggregates across all partitions. For records-lead, it seems that it's better to add the topic partition as a tag, instead of as a prefix in the metric name.
Jun On Thu, Nov 9, 2017 at 1:03 AM, Hu Xi <huxi...@hotmail.com> wrote: > Hi all, > > > As per Jun Rao's suggestion, I opened up the KIP-223(https://cwiki.apache. > org/confluence/display/KAFKA/KIP-223+-+Add+per-topic+min+ > lead+and+per-partition+lead+metrics+to+KafkaConsumer) concerning adding > new kinds of lag metrics for KafkaConsumer. Be free to leave your comments > here. Thanks in advance. > >
