GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/4227
MINOR: Log unexpected exceptions in Connect REST calls that generate 500s
at a higher log level
The ConnectExceptionMapper was originally intended to handle
ConnectException errors for some expected cases where we just want to always
convert them to a certain response and the ExceptionMapper was the easiest way
to do that uniformly across the API. However, in the case that it's not an
expected subclass, we should log the information at the error level so the user
can track down the cause of the error.
This is only an initial improvement. We should probably also add a more
general ExceptionMapper to handle other exceptions we may not have caught and
converted to ConnectException.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka better-connect-error-logging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4227.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4227
----
commit a2d750a87efc2ac49d6f0b7954488a7deb9f47cc
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2017-11-16T23:45:36Z
MINOR: Log unexpected exceptions in Connect REST calls that generate 500s
at a higher log level
----
---
