Thanks for the clarification Jason. Your suggestions make sense. I'll leave individual offset deletion and exposing the functionality in AdminClient out of this KIP.
--Vahid From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 12/12/2017 01:46 PM Subject: Re: [DISCUSS] KIP-229: DeleteGroups API > > That makes sense. I'll add that functionality in the KIP. This was in response to my suggestion about deleting offsets. After thinking about it some more, it might be better to leave it as potential future work. I wouldn't want to complicate the DeleteGroups API unnecessarily, and the ability to reset the offset for a topic partition is probably good enough for most situations. What do you think? > I exposed this functionality through AdminClient based on Ding's > suggestion earlier that users would benefit from it programmatically. If > we want to be consistent wrt. admin functions in AdminClient, I'll remove > it from the KIP. To clarify, there are two AdminClients: the scala one is internal and will probably be removed eventually. The newer AdminClient is available in kafka-clients and is a public interface. I think this is the one Dong was referring to. I thought it might be a little premature since we don't have any other group APIs supported. That said, there is a separate proposal to expose list/describe functionality, so if that gets in, we could add support for deletion as well. -Jason On Tue, Dec 12, 2017 at 1:30 PM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Hi Jason, > > Thanks for reviewing the KIP. Please see my responses inline. > I'll make the necessary updates to the KIP and send another note once > that's done. > > --Vahid > > > > From: Jason Gustafson <ja...@confluent.io> > To: dev@kafka.apache.org > Date: 12/11/2017 03:43 PM > Subject: Re: [DISCUSS] KIP-229: DeleteGroups API > > > > Hi Vahid, > > Seems reasonable to me. A few questions. > > 1. What error code do we use when the group is not empty? > > *** Thanks for pointing our this use case. I suggest introducing an error > code (e.g. NON_EMPTY_GROUP) for this case. It seems none of the existing > codes is a good fit here. > > 2. Do we need the capability to delete offsets individually for a > partition? I ask because the offset tool lets you set the offset for > partitions individually, so it might be natural to expect you could also > delete them individually. We could leave this as potential future work if > the use case is not too compelling. > > *** That makes sense. I'll add that functionality in the KIP. > > 3. Looks like you've added this API to the internal AdminClient. Wanted to > check if that was intentional. Since the public AdminClient doesn't > support > any of the group admin capabilities, I think it's reasonable to leave it > out of this KIP. > > *** I exposed this functionality through AdminClient based on Ding's > suggestion earlier that users would benefit from it programmatically. If > we want to be consistent wrt. admin functions in AdminClient, I'll remove > it from the KIP. > > Thanks, > Jason > > > >
