Guozhang Wang created KAFKA-6363:
------------------------------------
Summary: Use MockAdminClient for any unit tests that depend on
AdminClient
Key: KAFKA-6363
URL: https://issues.apache.org/jira/browse/KAFKA-6363
Project: Kafka
Issue Type: Bug
Reporter: Guozhang Wang
Today we have a few unit tests other than KafkaAdminClientTest that relies on
MockKafkaAdminClientEnv.
About this class and MockKafkaAdminClientEnv, my thoughts:
1. MockKafkaAdminClientEnv is actually using a MockClient for the inner
KafkaClient; it should be only used for the unit test of KafkaAdminClient
itself.
2. For any other unit tests on classes that depend on AdminClient, we should be
using the MockAdminClient that mocks the whole AdminClient.
So I suggest 1) in TopicAdminTest use MockAdminClient instead; 2) in
KafkaAdminClientTest use MockClient and added a new static constructor that
takes a KafkaClient; 3) remove the MockKafkaAdminClientEnv.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
