+1, thanks On Fri, Jan 12, 2018 at 10:38 AM, Randall Hauch <rha...@gmail.com> wrote:
> +1 (non-binding) > > On Mon, Jan 8, 2018 at 7:09 PM, Gwen Shapira <g...@confluent.io> wrote: > > > +1 binding > > > > On Mon, Jan 8, 2018 at 4:59 PM Ewen Cheslack-Postava <e...@confluent.io> > > wrote: > > > > > +1 binding. Thanks for the KIP! > > > > > > -Ewen > > > > > > On Mon, Jan 8, 2018 at 8:34 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > > > +1 > > > > > > > > On Mon, Jan 8, 2018 at 4:27 AM, UMESH CHAUDHARY <umesh9...@gmail.com > > > > > > wrote: > > > > > > > > > Hello All, > > > > > Since there are no outstanding comments on this, so I'd like to > > start a > > > > > vote. > > > > > > > > > > Please find the KIP here > > > > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > 174+-+Deprecate+and+remove+internal+converter+configs+in+ > > WorkerConfig> > > > > > and > > > > > the related JIRA here < > > > https://issues.apache.org/jira/browse/KAFKA-5540 > > > > >. > > > > > > > > > > The KIP suggests to deprecate and remove the configs: > > > > > internal.key.converter, internal.value.converter > > > > > > > > > > Appreciate your comments. > > > > > > > > > > Regards, > > > > > Umesh > > > > > > > > > > > > > > > -- -- Guozhang