+1 (non-binding). Thanks. On Thu, May 10, 2018 at 2:33 PM, Mickael Maison <mickael.mai...@gmail.com> wrote:
> +1 (non binding) > Thanks > > On Thu, May 10, 2018 at 9:39 AM, Rajini Sivaram <rajinisiva...@gmail.com> > wrote: > > Hi Richard, Thanks for the KIP. > > > > +1 (binding) > > > > Regards, > > > > Rajini > > > > On Wed, May 9, 2018 at 10:54 PM, Guozhang Wang <wangg...@gmail.com> > wrote: > > > >> +1 from me, thanks! > >> > >> > >> Guozhang > >> > >> On Wed, May 9, 2018 at 10:46 AM, Jason Gustafson <ja...@confluent.io> > >> wrote: > >> > >> > Thanks for the KIP, +1 (binding). > >> > > >> > One small correction: the KIP mentions that close() will be > deprecated, > >> but > >> > we do not want to do this because it is needed by the Closeable > >> interface. > >> > We only want to deprecate close(long, TimeUnit) in favor of > >> > close(Duration). > >> > > >> > -Jason > >> > > >> > On Tue, May 8, 2018 at 12:43 AM, khaireddine Rezgui < > >> > khaireddine...@gmail.com> wrote: > >> > > >> > > +1 > >> > > > >> > > 2018-05-07 20:35 GMT+01:00 Bill Bejeck <bbej...@gmail.com>: > >> > > > >> > > > +1 > >> > > > > >> > > > Thanks, > >> > > > Bill > >> > > > > >> > > > On Fri, May 4, 2018 at 7:21 PM, Richard Yu < > >> yohan.richard...@gmail.com > >> > > > >> > > > wrote: > >> > > > > >> > > > > Hi all, I would like to bump this thread since discussion in the > >> KIP > >> > > > > appears to be reaching its conclusion. > >> > > > > > >> > > > > > >> > > > > > >> > > > > On Thu, Mar 15, 2018 at 3:30 PM, Richard Yu < > >> > > yohan.richard...@gmail.com> > >> > > > > wrote: > >> > > > > > >> > > > > > Hi all, > >> > > > > > > >> > > > > > Since there does not seem to be too much discussion in > KIP-266, I > >> > > will > >> > > > be > >> > > > > > starting a voting thread. > >> > > > > > Here is the link to KIP-266 for reference: > >> > > > > > > >> > > > > > https://cwiki.apache.org/confluence/pages/viewpage. > >> > > > > action?pageId=75974886 > >> > > > > > > >> > > > > > Recently, I have made some updates to the KIP. To reiterate, I > >> have > >> > > > > > included KafkaConsumer's commitSync, > >> > > > > > poll, and committed in the KIP. (we will be adding to a > >> > > > TimeoutException > >> > > > > > to them as well, in a similar manner > >> > > > > > to what we will be doing for position()) > >> > > > > > > >> > > > > > Thanks, > >> > > > > > Richard Yu > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > Ingénieur en informatique > >> > > > >> > > >> > >> > >> > >> -- > >> -- Guozhang > >> >