Hi, I'd like to point out that:
org.apache.kafka.streams.test.ConsumerRecordFactory Has also been included as part of this KIP to support changes on test cases, just in case there is additional feedback here. Cheers, Jorge. El lun., 21 may. 2018 a las 16:46, Jorge Esteban Quilcate Otoya (< quilcate.jo...@gmail.com>) escribió: > Thanks for your votes and your feedback. > > This KIP has been approved with the following results: > > Binding +1s: 3 (Matthias, Damina, Guozhang) > Non-biniding +1s: (Bill, Ted) > > Jorge. > > El mar., 15 may. 2018 a las 20:01, Bill Bejeck (<bbej...@gmail.com>) > escribió: > >> Thanks for the KIP! >> >> +1 >> >> -Bill >> >> On Tue, May 15, 2018 at 1:47 PM, Damian Guy <damian....@gmail.com> wrote: >> >> > Thanks. +1 (binding) >> > >> > On Tue, 15 May 2018 at 01:04 Jorge Esteban Quilcate Otoya < >> > quilcate.jo...@gmail.com> wrote: >> > >> > > @Guozhang added. Thanks! >> > > >> > > El mar., 15 may. 2018 a las 5:50, Matthias J. Sax (< >> > matth...@confluent.io >> > > >) >> > > escribió: >> > > >> > > > +1 (binding) >> > > > >> > > > Thanks a lot for the KIP! >> > > > >> > > > -Matthias >> > > > >> > > > On 5/14/18 10:17 AM, Guozhang Wang wrote: >> > > > > +1 from me >> > > > > >> > > > > One more comment on the wiki: while reviewing the PR I realized >> that >> > > in ` >> > > > > MockProcessorContext.java >> > > > > < >> > > > >> > > https://github.com/apache/kafka/pull/4955/files#diff- >> > d5440e7338f775230019a86e6bcacccb >> > > > >` >> > > > > we are also adding one additional API plus modifying the existing >> > > > > `setRecordMetadata` API. Since this class is part of the public >> > > > test-utils >> > > > > package we should claim it in the wiki as well. >> > > > > >> > > > > >> > > > > Guozhang >> > > > > >> > > > > On Mon, May 14, 2018 at 8:43 AM, Ted Yu <yuzhih...@gmail.com> >> wrote: >> > > > > >> > > > >> +1 >> > > > >> >> > > > >> On Mon, May 14, 2018 at 8:31 AM, Jorge Esteban Quilcate Otoya < >> > > > >> quilcate.jo...@gmail.com> wrote: >> > > > >> >> > > > >>> Hi everyone, >> > > > >>> >> > > > >>> I would like to start a vote on KIP-244: Add Record Header >> support >> > to >> > > > >> Kafka >> > > > >>> Streams >> > > > >>> >> > > > >>> KIP wiki page: >> > > > >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> > > > >>> 244%3A+Add+Record+Header+support+to+Kafka+Streams+Processor+API >> > > > >>> >> > > > >>> The discussion thread is here: >> > > > >>> http://mail-archives.apache.org/mod_mbox/kafka-dev/201805. >> > > > >>> >> mbox/%3CCAC3UcJvrgcBfe6%3DiW6%2BuTWsLB%2B4CsHgRmDx9TvCzJQrWvfg7_w% >> > > > >>> 40mail.gmail.com%3E >> > > > >>> >> > > > >>> Cheers, >> > > > >>> Jorge. >> > > > >>> >> > > > >> >> > > > > >> > > > > >> > > > > >> > > > >> > > > >> > > >> > >> >
