Thanks for starting this conversation, Stephane. I have a few questions. The worker already accepts nearly all producer properties already, and all `producer.*` properties override any hard-coded properties defined in `Worker.java`. So isn't it currently possible for a user to define these properties in their worker configuration if they want?
Second, wouldn't this change the default behavior for existing worker configurations that have not overridden these properties? IOW, we would need to address the migration path to ensure backward compatibility. Third, the KIP mentions but does not really address the problem of running workers against pre-1.0 Kafka clusters. That definitely is something that happens frequently, so what is the planned approach for addressing this compatibility concern? All of these factors are likely why this has not yet been addressed to date: it's already possible for users to enable this feature, but doing it by default has compatibility concerns. Thoughts? Best regards, Randall On Wed, Jun 20, 2018 at 1:17 AM, Stephane Maarek < steph...@simplemachines.com.au> wrote: > KIP link: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 318%3A+Make+Kafka+Connect+Source+idempotent > > > By looking at the code, it seems Worker.java is where the magic happens, > but do we need to also operate changes to KafkaBasedLog.java (~line 241) ? > > Love to hear your thoughts! >
