@Dhruvil: Yes, I had "suppress.auto.topic.creation" or "allow.auto.topic.creation" in mind.
@Brandon: I think it would be "allow=false" or "suppress=true" to enable this feature. Ie, default values would be "allow=true" or "suppress=false". Not sure if this changes any preferences for you. -Matthias On 8/22/18 8:29 PM, Ismael Juma wrote: > 1 seems reasonable to me, would be good to hear other opinions. > > With regards to 2, yes, we discussed deprecating and eventually removing > the server config. But we'd like to make it easier to get auto create > behaviour on the producer (and maybe the consumer although that's less > clear) before we do that. Since the broker has to support older clients, > it's probably going to be a long time before we can remove it there though. > > Ismael > > On Wed, Aug 22, 2018 at 7:21 PM Dhruvil Shah <dhru...@confluent.io> wrote: > >> Hi Ismael, >> >> Thanks for the comments. Replies below. >> >> 1. We could throw an InvalidConfigurationException at run-time either when >> building the MetadataRequest or when an ApiVersions response is received. >> Because this is a configuration problem, I think users would likely see the >> exception on the first call to poll. Does this sound reasonable? >> >> 2. I think we could log a warning when KafkaConsumer is instantiated with >> the default configuration. Is there a plan to deprecate the server >> configuration? Is so, we could employ the same strategy in terms of when to >> switch the default value and then eventually remove the config altogether. >> >> - Dhruvil >> >> On Tue, Aug 21, 2018 at 7:36 PM Ismael Juma <isma...@gmail.com> wrote: >> >>> Thanks for the KIP. A few questions/comments: >>> >>> 1. It seems hard to reason about if we just disregard the config for >> older >>> brokers. Maybe we should throw an error if the brokers don't support it >> and >>> let users explicitly change the config if they want to. >>> >>> 2. We probably want to switch the default and eventually remove this >> config >>> in a future version. What's the path to making that happen? One option >>> would be to warn if people rely on the default as a first step (or warn >>> every time it's used). >>> >>> Ismael >>> >>> On 21 Aug 2018 3:56 pm, "Dhruvil Shah" <dhru...@confluent.io> wrote: >>> >>> Hi, >>> >>> I would like to start discussion on KIP-361 that proposes we add a >> consumer >>> configuration to disable auto topic creation. >>> >>> Link to the KIP: >>> >>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-361%3A+Add+Consumer+Configuration+to+Disable+Auto+Topic+Creation >>> >>> Suggestions and feedback are welcome! >>> >>> Thanks, >>> Dhruvil >>> >> >
signature.asc
Description: OpenPGP digital signature
