Hi Jun, Yes, my intention was to have them per logDir but I failed to mention it in the KIP. Updated.
Thanks, Stan On Fri, Aug 24, 2018 at 12:00 AM Jun Rao <j...@confluent.io> wrote: > Hi, Stan, > > Thanks for the KIP. Looks good to me overall. Just one comment below. > > uncleanable-partitions-count is per logDir, but uncleanable-bytes is not. > Should we make them consistent? > > Jun > > > On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski < > stanis...@confluent.io > > wrote: > > > Hi everybody, > > > > @Jason - I've updated the section. Thanks for the reminder > > > > I'm glad to say that the vote *has passed* with 3 binding votes (Jason, > > Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael, > Manikumar, > > Ray, Ted, Thomas). > > > > The PR is ready for review at https://github.com/apache/kafka/pull/5439 > > > > On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson <ja...@confluent.io> > > wrote: > > > > > +1 Thanks for the KIP! I'd suggest mentioning the configurations that > > were > > > previously proposed in the rejected alternatives section. We may > > reconsider > > > them in the future. > > > > > > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah <dhru...@confluent.io> > > > wrote: > > > > > > > Thanks for the KIP, Stanislav! +1 (non-binding) > > > > > > > > - Dhruvil > > > > > > > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe <cmcc...@apache.org> > > wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > best, > > > > > Colin > > > > > > > > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote: > > > > > > Hey everybody, > > > > > > I'm starting a vote on KIP-346 > > > > > > < > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > 346+-+Improve+LogCleaner+behavior+on+error > > > > > > > > > > > > > > > > > > -- > > > > > > Best, > > > > > > Stanislav > > > > > > > > > > > > > > > > > > -- > > Best, > > Stanislav > > > -- Best, Stanislav
