+1 (non-binding). Thanks, Chia-Ping.
best, On Fri, Sep 14, 2018, at 21:01, Chia-Ping Tsai wrote: > hi Colin > > > I like the idea of having a close(Duration) call. I would rather keep the > > existing close(long, TimeUnit) call to avoid breaking compatibility, > > however. Does the KIP specify keeping the old overload? I can't seem to > > access the wiki now. > > As Ismael said. All existing close(long, TimeUnit) aren't removed but > all of them are marked as "deprecated". > > -- > Chia-Ping > > On 2018/09/14 21:06:13, Colin McCabe <cmcc...@apache.org> wrote: > > Hi Chia-Ping, > > > > I like the idea of having a close(Duration) call. I would rather keep the > > existing close(long, TimeUnit) call to avoid breaking compatibility, > > however. Does the KIP specify keeping the old overload? I can't seem to > > access the wiki now. > > > > best, > > Colin > > > > > > On Sat, Sep 8, 2018, at 11:27, Chia-Ping Tsai wrote: > > > Hi All, > > > > > > I'd like to put KIP-367 to the vote. > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496 > > > > > > -- > > > Chia-Ping > >
