Hi Yishun, Thank you for your great KIP. In fact, I have also encountered the cases where Autoclosable is so desired several times! Let me inspect more candidate classes as well.
+1. I also refined your KIP a little bit. Best, Dongjin On Thu, Sep 27, 2018 at 12:21 PM Chia-Ping Tsai <chia7...@apache.org> wrote: > hi Yishun > > Thanks for nice KIP! > > Q1) > Why VerifiableProducer extend Closeable rather than AutoCloseable? > > Q2) > I grep project and then noticed there are other close methods but do not > implement AutoCloseable. > For example: > 1) WorkerConnector > 2) MemoryRecordsBuilder > 3) MetricsReporter > 4) ExpiringCredentialRefreshingLogin > 5) KafkaChannel > 6) ConsumerInterceptor > 7) SelectorMetrics > 8) HeartbeatThread > > Cheers, > Chia-Ping > > > On 2018/09/26 23:44:31, Yishun Guan <gyis...@gmail.com> wrote: > > Hi All, > > > > Here is a trivial KIP: > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=93325308 > > > > Suggestions are welcome. > > > > Thanks, > > Yishun > > > -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: <http://goog_969573159/>github.com/dongjinleekr <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr <http://kr.linkedin.com/in/dongjinleekr>slideshare: www.slideshare.net/dongjinleekr <http://www.slideshare.net/dongjinleekr>*
